Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra: Adjust publish action for AWS ECR #794

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Infra: Adjust publish action for AWS ECR #794

merged 1 commit into from
Jan 30, 2025

Conversation

yermulnik
Copy link
Contributor

@yermulnik yermulnik commented Jan 21, 2025 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Ref: #242

Improve publishig to Public AWS ECR by trimming repo owner from repo name so that Public ERC repo url has no duplcates.
Before: public.ecr.aws/kafbat/kafbat/kafka-ui
After: public.ecr.aws/kafbat/kafka-ui

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@yermulnik
infra(docker_publish): public.ecr.aws improvements
64be860 
Ref: kafbat#242

Improve publishig to Public AWS ECR by trimming repo owner from repo name
so that Public ERC repo url has no duplcates.
Before: `public.ecr.aws/kafbat/kafbat/kafka-ui`
After: `public.ecr.aws/kafbat/kafka-ui`
@yermulnik yermulnik requested a review from a team as a code owner January 21, 2025 15:08
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 21, 2025
github-actions[bot]
github-actions bot reviewed Jan 21, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi yermulnik! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@yermulnik yermulnik mentioned this pull request Jan 21, 2025
Closed
2 tasks
@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. and removed status/triage/manual Manual triage in progress labels Jan 30, 2025
@Haarolean Haarolean changed the title infra(docker_publish): public.ecr.aws improvements Infra: Adjust publish action for AWS ECR Jan 30, 2025
@Haarolean Haarolean merged commit 840a5c2 into kafbat:main Jan 30, 2025
11 checks passed
@Haarolean Haarolean added this to the 1.2 milestone Jan 30, 2025
@yermulnik yermulnik deleted the gha/improve_docker_publish_workflow branch January 30, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed
Projects
Release 1.2
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@yermulnik @Haarolean