Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Principal account creation flow #776

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

jmininger
Copy link
Contributor

Adds principal account autofill to gtransfer
TODO:

  • Offer same functionality in the "Watch Account" dialog
  • Add checks to gtransfer that validate other principals not possible to construct with keysets
  • Add a convenient way to use a principal multisig from another chain without having to manually input the keys (unless the existing account has been rotated)

@@ -95,10 +95,8 @@ uiDeployedModuleList m mList = mdo
& setValue .~ onNetworkName

d <- uiDropdown Nothing opts filterCfg
onNewSearch <- debounce 0.2 $ _inputElement_input ti
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in the other PR but should resolve easily in the merge.

isPrincipalAccName = (==) ':' . flip T.index 1
toPrincipalAccName = AccountName . createKSPrincipal . userToPactKeyset

createKSPrincipal :: KeySet -> Text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if Pact supplied these (@jwiegley @jmcardon) but this is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants