Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dw): show alias for keys #2816

Merged
merged 1 commit into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/apps/dev-wallet/src/Components/Guard/KeySelector.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { useWallet } from '@/modules/wallet/wallet.hook';
import { shorten } from '@/utils/helpers';
import { BuiltInPredicate } from '@kadena/client';
import { MonoKey } from '@kadena/kode-icons/system';
import { Checkbox, Stack, Text } from '@kadena/kode-ui';
import { Badge, Checkbox, Stack, Text } from '@kadena/kode-ui';

export const KeySelector = ({
guard,
Expand All @@ -12,6 +13,11 @@ export const KeySelector = ({
onSelect: (keys: string[]) => void;
selectedKeys: string[];
}) => {
const { getKeyAlias } = useWallet();
const keysWithAlias = guard.keys.map((key) => ({
key,
alias: getKeyAlias(key),
}));
return (
<Stack
flexWrap="wrap"
Expand All @@ -21,11 +27,12 @@ export const KeySelector = ({
marginBlock={'xs'}
>
<Text size="smallest">{guard.pred}:</Text>
{guard.keys.map((key) => (
{keysWithAlias.map(({ key, alias }) => (
<Stack key={key} gap="sm" alignItems={'center'}>
<Text size="smallest">
<MonoKey />
</Text>
{keysWithAlias.length > 1 && <Badge size="sm">{alias}</Badge>}
<Text variant="code" size="smallest">
<Checkbox
isSelected={selectedKeys.includes(key)}
Expand All @@ -39,7 +46,7 @@ export const KeySelector = ({
onSelect(updated);
}}
>
{shorten(key!)}
{(<Text size="smallest">{shorten(key!)}</Text>) as any}
</Checkbox>
</Text>
</Stack>
Expand Down
56 changes: 33 additions & 23 deletions packages/apps/dev-wallet/src/Components/Guard/keyset.tsx
Original file line number Diff line number Diff line change
@@ -1,30 +1,40 @@
import { useWallet } from '@/modules/wallet/wallet.hook';
import { shorten } from '@/utils/helpers';
import { BuiltInPredicate } from '@kadena/client';
import { MonoKey } from '@kadena/kode-icons/system';
import { Stack, Text } from '@kadena/kode-ui';
import { Badge, Stack, Text } from '@kadena/kode-ui';
import { useMemo } from 'react';

export const Keyset = ({
guard,
}: {
guard: { keys: string[]; pred: BuiltInPredicate };
}) => (
<Stack
flexWrap="wrap"
flexDirection={'row'}
gap="md"
paddingInline={'sm'}
marginBlock={'xs'}
>
<Text size="smallest">{guard.pred}:</Text>
{guard.keys.map((key) => (
<Stack key={key} gap="sm" alignItems={'center'}>
<Text size="smallest">
<MonoKey />
</Text>
<Text variant="code" size="smallest">
{shorten(key!)}
</Text>
</Stack>
))}
</Stack>
);
guard: { keys: string[]; pred: BuiltInPredicate; principal: string };
}) => {
const { getKeyAlias } = useWallet();
const keysWithAlias = useMemo(
() => guard.keys.map((key) => ({ key, alias: getKeyAlias(key) })),
[getKeyAlias, guard.principal],
);
return (
<Stack
flexWrap="wrap"
flexDirection={'row'}
gap="md"
paddingInline={'sm'}
marginBlock={'xs'}
>
<Text size="smallest">{guard.pred}:</Text>
{keysWithAlias.map(({ key, alias }) => (
<Stack key={key} gap="sm" alignItems={'center'}>
<Text size="smallest">
<MonoKey />
</Text>
{keysWithAlias.length > 1 && <Badge size="sm">{alias}</Badge>}
<Text variant="code" size="smallest">
{shorten(key!)}
</Text>
</Stack>
))}
</Stack>
);
};
68 changes: 68 additions & 0 deletions packages/apps/dev-wallet/src/modules/wallet/wallet.hook.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,73 @@ export const useWallet = () => {
throw new Error('useWallet must be used within a WalletProvider');
}

const getKeyAlias = useCallback(
(publicKey: string) => {
const singleKeyAccount = context.accounts.find(
(a) =>
isKeysetGuard(a.guard) &&
a.guard.keys.length === 1 &&
a.guard.keys[0] === publicKey,
);

if (
singleKeyAccount &&
(singleKeyAccount.alias || singleKeyAccount.address.length < 15)
) {
return singleKeyAccount.alias || singleKeyAccount.address;
}

const contactSingleKey = context.contacts.find(
(c) =>
isKeysetGuard(c.account.guard) &&
c.account.guard.keys.length === 1 &&
c.account.guard.keys[0] === publicKey,
);

if (
contactSingleKey &&
(contactSingleKey.name || contactSingleKey.account.address.length < 15)
) {
return contactSingleKey.name || contactSingleKey.account.address;
}

const multiKeyAccount = context.accounts.find(
(a) =>
isKeysetGuard(a.guard) &&
a.guard.keys.length > 1 &&
a.guard.keys.includes(publicKey),
);

if (
multiKeyAccount &&
isKeysetGuard(multiKeyAccount.guard) &&
(multiKeyAccount.alias || multiKeyAccount.address.length < 15)
) {
const name = multiKeyAccount.alias || multiKeyAccount.address;
return `${name}-key(${multiKeyAccount.guard.keys.indexOf(publicKey) + 1})`;
}

const contactMultiKey = context.contacts.find(
(c) =>
isKeysetGuard(c.account.guard) &&
c.account.guard.keys.length > 1 &&
c.account.guard.keys.includes(publicKey),
);

if (
contactMultiKey &&
isKeysetGuard(contactMultiKey.account.guard) &&
(contactMultiKey.name || contactMultiKey.account.address.length < 15)
) {
const name = contactMultiKey.name || contactMultiKey.account.address;
return `${name}-key(${contactMultiKey.account.guard.keys.indexOf(publicKey) + 1})`;
}

return '';
},
[context.accounts, context.contacts],
);

const getPublicKeyData = useCallback(
(publicKey: string) => {
if (!context.keySources) return null;
Expand Down Expand Up @@ -415,5 +482,6 @@ export const useWallet = () => {
...context,
accounts,
watchAccounts,
getKeyAlias,
};
};
35 changes: 22 additions & 13 deletions packages/apps/dev-wallet/src/pages/account/account.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
MonoWallet,
} from '@kadena/kode-icons/system';
import {
Badge,
Button,
Heading,
Stack,
Expand Down Expand Up @@ -54,6 +55,7 @@ export function AccountPage() {
watchAccounts,
client,
isOwnedAccount,
getKeyAlias,
} = useWallet();
const [redistributionGroupId, setRedistributionGroupId] = useState<string>();
const account =
Expand Down Expand Up @@ -296,21 +298,28 @@ export function AccountPage() {
{account.guard.pred}
</Text>
</Stack>
<Stack flexDirection={'column'} gap={'sm'}>
<Stack flexDirection={'column'} gap={'md'}>
<Text>Keys</Text>
{account.guard.keys.map((key) => (
<Stack
key={key}
gap="sm"
alignItems={'center'}
className={addressBreakClass}
>
<Text>
<MonoKey />
</Text>
<Text variant="code" color="emphasize">
{key}
</Text>
<Stack key={key} gap="sm" flexDirection={'column'}>
<Stack key={key} gap="sm" alignItems={'center'}>
{isKeysetGuard(account.guard) &&
account.guard.keys.length > 1 && (
<Badge size="sm">{getKeyAlias(key)}</Badge>
)}
</Stack>
<Stack gap="sm" alignItems={'center'}>
<Text>
<MonoKey />
</Text>
<Text
variant="code"
color="emphasize"
className={addressBreakClass}
>
{key}
</Text>
</Stack>
</Stack>
))}
</Stack>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@ import {
parseAsPactValue,
} from '@kadena/client';
import {
Badge,
Button,
Heading,
Notification,
Stack,
Text,
TextareaField,
} from '@kadena/kode-ui';
import { FC, PropsWithChildren, useState } from 'react';
import { FC, PropsWithChildren, useMemo, useState } from 'react';
import {
breakAllClass,
codeClass,
Expand Down Expand Up @@ -51,12 +52,16 @@ export const RenderSigner = ({
transactionStatus: ITransaction['status'];
onSign: (sig: ITransaction['sigs']) => void;
}) => {
const { getPublicKeyData, sign } = useWallet();
const { getPublicKeyData, sign, getKeyAlias } = useWallet();
const signature = transaction.sigs.find(
(sig) => sig?.pubKey === signer.pubKey && sig.sig,
)?.sig;
const info = getPublicKeyData(signer.pubKey);
const [error, setError] = useState<string>();
const keyAlias = useMemo(
() => getKeyAlias(signer.pubKey),
[signer.pubKey, getKeyAlias],
);
return (
<>
<Stack gap={'sm'}>
Expand All @@ -65,7 +70,11 @@ export const RenderSigner = ({
{!signature && info && <Text className={readyToSignClass}>Owned</Text>}
{<Text className={tagClass}>{info?.source ?? 'External'}</Text>}
</Stack>
<Value className={breakAllClass}>{signer.pubKey}</Value>

<Stack gap={'sm'} alignItems={'center'}>
{keyAlias && <Badge size="sm">{keyAlias}</Badge>}
<Value className={breakAllClass}>{signer.pubKey}</Value>
</Stack>
<Stack gap={'sm'} justifyContent={'space-between'}></Stack>
<Stack gap={'sm'} flexDirection={'column'}>
<Heading variant="h5">Sign for</Heading>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,8 @@ export function TransferForm({

const senderChain = watch('chain');

const isSafeTransfer = watch('type') === 'safeTransfer';

return (
<form onSubmit={handleSubmit(onSubmitForm)}>
<Stack flexDirection="column" gap="md" flex={1} width="100%">
Expand Down Expand Up @@ -664,9 +666,7 @@ export function TransferForm({
<Stack flexDirection={'column'}>
<AccountSearchBox
accounts={filteredAccounts}
hideKeySelector={
getValues('type') !== 'safeTransfer'
}
hideKeySelector={!isSafeTransfer}
watchedAccounts={
filteredWatchedAccounts
}
Expand Down
Loading