Make retouch_object more consistent #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying, throwing, and wielding stuff all worked slightly differently with regards to artifact blast, material hatred, and demons & silver. Furthermore, what things touch your skin was different in different places---you might wear something fine, then retouch your equipment and suddenly get blasted. Now, things are (hopefully) all consistent. In cases of contradiction, I tried to prioritize later and/or Evilhack-specific commits. Direct skin contact is prevented in the following cases, all of which were sometimes the case already and sometimes weren't: -if you're wearing gloves, you won't contact wielded/thrown/otherwise manipulated objects, or a worn shield -if you're wearing the Hand of Vecna, you won't contact your left ring -if you're wearing a shirt, you won't contact body armor or a cloak -if you're wearing body armor, you won't contact a cloak If you aren't directly contacting something, you won't suffer damage from its material, or suffer regen penalties as an orc/elf/drow wielding/wearing hated materials. This is unchanged from before. Direct contact has no bearing on artifact blast, just like in vanilla. This is a change from how Evilhack has worked for years. Demons cannot suffer even indirect contact from silver. This is largely unchanged save the fixing of a few edge cases. If you touch an artifact made of a material you hate, you will be blasted if applicable, and material damage will occur separately if you directly contact the artifact.
If an artifact hates your kind, it shouldn't care about gloves.
In the course of testing the retouch_objects code, a bug was found in how taking off armor was handled when you had wings. This had a simple one-line fix, but in the course of testing it, another bug was found in how armor was put *on* when you were winged, and more generally how hard body armor and big wings interacted with other kinds of flying. Fixing this involved tinkering with the definition of Flying, which I'm not a huge fan of, but I tested different sources of flying and BFlying extensively after the changes, so here's hoping it holds up.
Make ^O dungeon overview show the Planes in the correct, randomized order.
|
Nice job on all of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying, throwing, and wielding stuff all worked slightly differently with regards to artifact blast, material hatred, and demons & silver. Furthermore, what things touch your skin was different in different places---you might wear something fine, then have to retouch your equipment for some reason and suddenly get blasted. Now, things are (hopefully) all consistent. In cases of contradiction, I tried to prioritize later and/or Evilhack-specific commits.
Direct skin contact is prevented in the following cases, all of which were sometimes the case already and sometimes weren't:
-if you're wearing gloves, you won't contact wielded/thrown/otherwise manipulated objects, or a worn shield
-if you're wearing the Hand of Vecna, you won't contact your left ring
-if you're wearing a shirt, you won't contact body armor or a cloak
-if you're wearing body armor, you won't contact a cloak
If you aren't directly contacting something, you won't suffer damage from its material, or suffer regen penalties as an orc/elf/drow wielding/wearing hated materials. This is unchanged from before.
Direct contact has no bearing on artifact blast, just like in vanilla. This is a change from how Evilhack has worked for years. Demons cannot suffer even indirect contact from silver. This is largely unchanged save the fixing of a few edge cases. If you touch an artifact made of a material you hate, you will be blasted if applicable, and material damage will occur separately if you directly contact the artifact.