Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched goccy/go-yaml temporarily #888

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Use patched goccy/go-yaml temporarily #888

merged 6 commits into from
Apr 22, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 22, 2024

Use patched goccy/go-yaml ( goccy/go-yaml#440 )

ref: #851

@k1LoW k1LoW self-assigned this Apr 22, 2024

This comment has been minimized.

@k1LoW k1LoW force-pushed the patched-goccy-go-yaml branch from 394b888 to 3d272ff Compare April 22, 2024 05:40

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW force-pushed the patched-goccy-go-yaml branch from 967c1a8 to 367edd0 Compare April 22, 2024 14:10
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #888 (7eee294) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,751,132,000 ns/op 3,694,056,594 ns/op -57,075,406 ns/op
Bytes allocated per iteration 1,792,316,664 B/op 1,791,920,616 B/op -396,048 B/op
Allocs per iteration 21,406,695 allocs/op 21,406,873 allocs/op 178 allocs/op
Metadata
main (-) #888 (7eee294)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #888 (7eee294) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,515,725,840 ns/op 5,622,423,555 ns/op 106,697,715 ns/op
Bytes allocated per iteration 3,230,014,856 B/op 3,230,274,232 B/op 259,376 B/op
Allocs per iteration 31,110,936 allocs/op 31,111,195 allocs/op 259 allocs/op
Metadata
main (-) #888 (7eee294)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #888 (7eee294) +/-
Number of iterations 18 18 0
Nanoseconds per iteration 63,213,599 ns/op 64,059,868 ns/op 846,269 ns/op
Bytes allocated per iteration 60,191,781 B/op 60,321,020 B/op 129,239 B/op
Allocs per iteration 205,670 allocs/op 205,779 allocs/op 109 allocs/op
Metadata
main (-) #888 (7eee294)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

@k1LoW k1LoW marked this pull request as ready for review April 22, 2024 14:13
Copy link
Contributor

Code Metrics Report

main (8ca3977) #888 (7eee294) +/-
Coverage 65.9% 65.9% -0.0%
Code to Test Ratio 1:0.7 1:0.8 +0.1
Test Execution Time 3m40s 4m3s +23s
Details
  |                     | main (8ca3977) | #888 (7eee294) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          65.9% |          65.9% | -0.0% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |           7606 |           7606 |     0 |
- |   Covered           |           5012 |           5011 |    -1 |
+ | Code to Test Ratio  |          1:0.7 |          1:0.8 |  +0.1 |
  |   Code              |          13724 |          22236 | +8512 |
+ |   Test              |          10250 |          18600 | +8350 |
- | Test Execution Time |          3m40s |           4m3s |  +23s |

Code coverage of files in pull request scope (76.8% → 76.8%)

Files Coverage +/-
book.go 78.0% 0.0%
eval.go 87.2% 0.0%
http_validator.go 81.2% 0.0%
loop.go 90.9% 0.0%
parse.go 72.9% 0.0%
runbook.go 81.5% 0.0%
runner_option.go 40.2% 0.0%
vars.go 91.2% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit edaeba1 into main Apr 22, 2024
5 of 6 checks passed
@k1LoW k1LoW deleted the patched-goccy-go-yaml branch April 22, 2024 14:19
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
@k1LoW k1LoW changed the title Use patched goccy/go-yaml ( https://github.com/goccy/go-yaml/pull/440 ) Use patched goccy/go-yaml temporarily Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant