Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encountering Strange Behavior when upgrading runn #851

Closed
okazaki-kk opened this issue Mar 27, 2024 · 5 comments
Closed

Encountering Strange Behavior when upgrading runn #851

okazaki-kk opened this issue Mar 27, 2024 · 5 comments
Assignees
Labels
bug Something isn't working patched

Comments

@okazaki-kk
Copy link
Contributor

Hello! Thanks for this awesome software !

This is a very rare case and we may not have to take care of it, but I would like to report that when I update runn, the behavior was different and the error message reported strange lines.

In versions up to v0.92, example.yml passes, but in v0.93 and later, an error occurs.
Perhaps the backquote on line 7 is recognized as an invalid string, but the error message says line 4 is invalid.
This discrepancy is probably caused by the three lines of comments.

example.yml

desc: Example
# comment
# comment
# comment
steps:
  hello:
    desc: '`echo` hello' # ⇦ Single quote followed by backquote, line 7
    dump: "'Hello world!'"

version 0.100 (error)

➜  runn git:(main) runn --version      
runn version 0.100.0
➜  runn git:(main) runn run example.yml
Error: failed to load runbook example.yml: yaml: line 4: found character that cannot start any token

version0.92 (pass)

➜  runn git:(main) runn --version                   
runn version 0.92.0
➜  runn git:(main) ✗ runn run example.yml             
Hello world!
.

1 scenario, 0 skipped, 0 failures
@k1LoW k1LoW self-assigned this Mar 27, 2024
@k1LoW
Copy link
Owner

k1LoW commented Mar 27, 2024

@okazaki-kk Thank you for your report!

I will see which is the correct behavior.

@k1LoW
Copy link
Owner

k1LoW commented Mar 28, 2024

The behavior of v0.92.0 was found to be correct.

We are currently finding the cause and fixing it.

@k1LoW k1LoW added the bug Something isn't working label Mar 28, 2024
@k1LoW
Copy link
Owner

k1LoW commented Apr 10, 2024

We will be able to fix this when goccy/go-yaml#440 is merged and released.

@k1LoW
Copy link
Owner

k1LoW commented Apr 22, 2024

@okazaki-kk
Fixed at v0.104.0

@k1LoW k1LoW added the patched label Apr 24, 2024
@k1LoW
Copy link
Owner

k1LoW commented Jul 17, 2024

@k1LoW k1LoW closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patched
Projects
None yet
Development

No branches or pull requests

2 participants