_get_build_prefix() failing in jython-win environment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darjus
pushed a commit
that referenced
this pull request
Jan 7, 2016
pip/index.py: Add import of normalize_path
darjus
pushed a commit
that referenced
this pull request
Jan 7, 2016
Break long lines to make pep8 happy
darjus
pushed a commit
that referenced
this pull request
Jan 7, 2016
two major changes: 1) re-use the optparse options in pip.cmdoptions instead of maintaining a custom parser 2) as a result of #1, simplify the call stack from: parse_requirements -> parse_content -> parse_line to: parse_requirements -> process_line beyond #1/pypa#2, minor cosmetics and adjusting the tests to match
darjus
pushed a commit
that referenced
this pull request
Jan 7, 2016
and adjust the logic to match; the result is simpler. 2) Due to #1, we can remove some hairy "format_control" hacks 3) Due to #1, we have to relax the parsing and allow: - multiple options per line - any supported option on a line with a requirement (not just --install-option/--global-option, although they are the only options that are passed into a requirement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It affects bootstrapping ensurepip module under windows