sys.cleanup() in PythonInterpreter close() method closing thread pool _socket.NIO_GROUP in _socket.py #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… _socket.NIO_GROUP in _socket.py Recreating NIO_GROUP pool if it is shutdown..
jamesmudd
reviewed
Jul 5, 2017
| @@ -1550,6 +1550,12 @@ def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT, | |||
| for the socket to bind as a source address before making the connection. | |||
| An host of '' or port 0 tells the OS to use the default. | |||
| """ | |||
| # Added check to recreate thread pool if it is already shutdown | |||
| if NIO_GROUP.isShutdown(): | |||
| log.debug("Theard pool is shutdown. Recreating...") | |||
|
Unfortunately a PR (unlike an issue) cannot be transferred to the new official home at https://github.com/jython/jython. Keeping this open in the frozen-mirror to allow for further consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating NIO_GROUP pool if it is shutdown..