Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gym custom meal settings / no meal #54

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Fix gym custom meal settings / no meal #54

merged 1 commit into from
Dec 27, 2022

Conversation

Shurikal
Copy link
Contributor

#45

jxx123
jxx123 reviewed Dec 27, 2022
View reviewed changes
Copy link
Owner

@jxx123 jxx123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix! It looks good to me, and I am still waiting for the workflow tests to be done before approving your merge.

jxx123
jxx123 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Owner

@jxx123 jxx123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests are passed. I will approve and merge the pull request.

[Optional] It would be very nice if you could add a unit test for this fix.

@jxx123 jxx123 merged commit a2abc77 into jxx123:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxx123 jxx123 jxx123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shurikal @jxx123