Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return truthy value on success #628

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Oct 3, 2024

Description

Still one regression in the old methods.

They were returning truthy values so chains like this would stop working:

::JWT::Verify.verify_claims(payload, options) && validate_more(payload)

This change addresses that by returning true.

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj anakinj force-pushed the fix-return-value-regression branch from 554eee2 to 8890aa9 Compare October 3, 2024 05:13
@anakinj anakinj merged commit 6335f5e into jwt:main Oct 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant