Use correct arguments for custom algo example

[aedryan]

Description

Documentation for OpenSSL::HMAC shows that the arguments are digest, key, data and the example has key and data mixed up.

https://docs.ruby-lang.org/en/master/OpenSSL/HMAC.html

Checklist

Before the PR can be merged be sure the following are checked:

• There are tests for the fix or feature added/changed
• A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

[anakinj]

I think the test is with the parameters flipped. If you have interest and time it would be great to verify that it works as intended: https://github.com/jwt/ruby-jwt/blob/main/spec/integration/readme_examples_spec.rb#L461

[anakinj]

Thanks @aedryan for noticing and even bigger thanks for taking a stab fixing it. As mentioned, I think the spec for the example in the readme would need the same treatment.

[anakinj]

This part should not be removed. Probably some merge issues when syncing with main...

[anakinj]

The changelog should only have additions in PRs. So would be great if you could bring back the red parts.

[aedryan]

Well I think I borked it up real good trying to reset from main and re-add the new version, I'll try again.

[anakinj]

:) good luck

[anakinj]

You don't need to worry about version numbers or anything. Just adding your entry above the - Your contribution here

[aedryan]

I think it's good now.

[anakinj]

Now the - Your contribution here was replaced. If you bring back that one we are good to go

[aedryan]

Added it back.

[anakinj]

Was just about to merge but there are some conflicts vs what is on main currently.

There was this 2.9.1 release in between that bumped the version in the changelog, think your branch is still based on the previous revision of main. If you would be so kind to do a rebase (and maybe also squashing the commits while at it)

Sorry for the back and forth and thank you for your patience.

[aedryan]

I squashed and rebased, I think it looks good now.

[aedryan]

I think the test is with the parameters flipped. If you have interest and time it would be great to verify that it works as intended: https://github.com/jwt/ruby-jwt/blob/main/spec/integration/readme_examples_spec.rb#L461

I get several warnings and pending tests when I run bundle exec appraisal rake test but the README spec seems to pass just fine.

[anakinj]

I get several warnings and pending tests when I run bundle exec appraisal rake test but the README spec seems to pass just fine.

I think it's fine, I think it's a bit tricky to get running with older versions of the openssl gem. The CI is green so tests are happy.

[anakinj]

Thank you @aedryan for your effort, and apologize for the confusing changelog activities. Some day we will automate it...