Skip to content

Fix Time.now casting causing false positive in verify_at#393

Closed
kevinreedy wants to merge 1 commit intojwt:mainfrom
kevinreedy:verify-at-bug
Closed

Fix Time.now casting causing false positive in verify_at#393
kevinreedy wants to merge 1 commit intojwt:mainfrom
kevinreedy:verify-at-bug

Conversation

@kevinreedy
Copy link

Fixes #353

@sourcelevel-bot
Copy link

Hello, @kevinreedy! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@anakinj
Copy link
Member

anakinj commented Dec 21, 2020

Im wondering if the condition should be inclusive (>=) to handle cases where the verification happen on the same second the token has been issued.

Also a test verifying the "same-second" token would be good. Mocking the Time.now.to_i in a test could be a way to tackle the different cases.

@anakinj
Copy link
Member

anakinj commented Jun 23, 2025

Structure has changed quite a lot since this was touched the last time. Closing this one for now. Please reopen/refresh if there is a need.

@anakinj anakinj closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issued At RFC type mismatch causing false postives on verify_at

2 participants