More interaction with supplementary views. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewsForKind:" methods
…iew messages to JNWCollectionViewDelegate protocol
| @@ -354,6 +358,17 @@ - (void)resetAllCellsAndSupplementaryViews { | |||
| } | |||
| } | |||
| [self.visibleCellsMap removeAllObjects]; | |||
|
|
|||
| if (_collectionViewFlags.delegateDidEndDisplayingSupplementaryView) | |||
| { | |||
There was a problem hiding this comment.
Any chance we could get these brackets on the previous line? Same for the other brackets in the diff.
|
Thank you for putting this together, your contribution is much appreciated. ✨ Just a few pedantic comments. Also, it looks like this might need a merge from head to pull cleanly. Thanks! |
Index paths are used with other Cocoa classes, and may contain more than 2 items. The default implementation of -isEqual should already handle the 2-item case correctly.
If a version that displays the section and item is needed, it should probably have a unique name. Messing with NSIndexPath globally can cause unexpected results elsewhere.
|
Sorry for taking this long. Cleaned up code and merged from head. |
| @@ -138,13 +143,16 @@ - (void)setDelegate:(id<JNWCollectionViewDelegate>)delegate { | |||
| _collectionViewFlags.delegateDidDeselect = [delegate respondsToSelector:@selector(collectionView:didDeselectItemAtIndexPath:)]; | |||
| _collectionViewFlags.delegateDidDoubleClick = [delegate respondsToSelector:@selector(collectionView:didDoubleClickItemAtIndexPath:)]; | |||
| _collectionViewFlags.delegateDidRightClick = [delegate respondsToSelector:@selector(collectionView:didRightClickItemAtIndexPath:)]; | |||
| _collectionViewFlags.delegateDidEndDisplayingCell = [delegate respondsToSelector:@selector(collectionView:didEndDisplayingCell:forItemAtIndexPath:)]; | |||
| _collectionViewFlags.delegateDidEndDisplayingCell = [delegate respondsToSelector:@selector(collectionView:didEndDisplayingCell:forItemAtIndexPath:)]; | |||
There was a problem hiding this comment.
Thanks! It seems like there's still a merge conflict. Can you run it through mergetool one more time? For me, the conflict happens right here. Sorry for the trouble!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added delegate messages about supplementary views being added and removed from document view:
Implemented methods to get visible supplementary views: