cfg: added check for key prefixes; #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4k4
force-pushed
the
conf_prefix_exists
branch
2 times, most recently
from
fbccc34
to
1e9b8b9
Compare
applike-ss
reviewed
Sep 11, 2023
Comment on lines
+18
to
+23
| func TestMemoryPrefixExists(t *testing.T) { | ||
| provider := cfg.NewMemoryEnvProvider(map[string]string{ | ||
| "GOSOLINE_TEST": "foobar", | ||
| }) | ||
| assert.True(t, provider.PrefixExists("GOSOLINE")) | ||
| } |
There was a problem hiding this comment.
should we test for something that can not have been set beforehand by a test in OS env to make sure this test is not erraneously passing?
j4k4
force-pushed
the
conf_prefix_exists
branch
from
1e9b8b9
to
3678226
Compare
j4k4
force-pushed
the
conf_prefix_exists
branch
from
3678226
to
58941aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks if there are config keys with a prefix