add Passkey button to example app #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameh-amwal
force-pushed
the
feature/add-passkey-button
branch
from
5de2c1c to
75bef48
Compare
sameh-amwal
force-pushed
the
feature/add-passkey-button
branch
from
75bef48 to
9e1ae48
Compare
knight6700
approved these changes
Oct 25, 2023
| if viewModel.hasPasskeys { | ||
| SignInPassKeysButton(action: { | ||
| Task { | ||
| await viewModel.loginPasskeys(window: sceneDelegate.window!, autofill: false) |
There was a problem hiding this comment.
We can use .init() instead, and it's advisable to avoid force unwrapping to prevent potential crashes.
There was a problem hiding this comment.
where should the .init() be?
Comment on lines
+30
to
+32
| Image(systemName: self.biometryType == .faceID | ||
| ? "faceid" | ||
| : "touchid") |
There was a problem hiding this comment.
i think it will better to move this to computed property will make it more readable what's ur opinion
self.biometryType == .faceID ? "faceid" : "touchid"
Comment on lines
+35
to
+36
| ? Color.blue | ||
| : Color.red.opacity(0.5)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.