Skip to content

Conversation

@thejfreitas
Copy link
Member

@thejfreitas thejfreitas commented Apr 1, 2025

Added items prop rendering the navigation items as well the separation among items.

Screenshot 2025-04-01 at 3 06 02 PM

Also added the capability to truncate the label from the last item.
Screenshot 2025-04-03 at 1 58 00 PM

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@thejfreitas thejfreitas self-assigned this Apr 1, 2025
@thejfreitas thejfreitas requested review from a team as code owners April 1, 2025 21:13
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 11c5402

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@justeattakeaway/pie-breadcrumb Minor
pie-storybook Minor
@justeattakeaway/pie-webc Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thejfreitas
Copy link
Member Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – one tiny comment, otherwise :shipit:

@thejfreitas thejfreitas requested a review from ashleynolan April 2, 2025 21:10
Copy link
Member

@raoufswe raoufswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of comments that we can address in follow up PRs.

@raoufswe raoufswe merged commit 57b5aea into main Apr 11, 2025
41 of 42 checks passed
@raoufswe raoufswe deleted the dsw-2834-pie-breadcrumb-implement-navigation-items-and-separation branch April 11, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants