-
Notifications
You must be signed in to change notification settings - Fork 11
feat(pie-breadcrumb): DSW-2834 implement navigation items and separation #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-breadcrumb): DSW-2834 implement navigation items and separation #2308
Conversation
…ation items and separator
…nd enhanced rendering logic
🦋 Changeset detectedLatest commit: 11c5402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements. |
ashleynolan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – one tiny comment, otherwise ![]()
…-items-and-separation
…ved listitem role to li element
…s to support text truncation
…ontaining large label
…-items-and-separation
…-items-and-separation
raoufswe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of comments that we can address in follow up PRs.
…-items-and-separation
Added
itemsprop rendering the navigation items as well the separation among items.Also added the capability to truncate the label from the last item.

Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.