Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-monorepo): DSW-000 fix lint #2103

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Dec 2, 2024

Describe your changes (can list changeset entries if preferable)

fixes linting issue to unblock #2101

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 27978e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raoufswe raoufswe marked this pull request as ready for review December 2, 2024 10:54
@raoufswe raoufswe requested review from a team as code owners December 2, 2024 10:54
@raoufswe raoufswe merged commit 7528fe1 into main Dec 2, 2024
52 of 53 checks passed
@raoufswe raoufswe deleted the dsw-000-fix-lin-storybook-ra branch December 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants