Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-button): DSW-000 styling allowing for text-overflow in buttons #1089

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ashleynolan
Copy link
Contributor

@ashleynolan ashleynolan commented Dec 9, 2023

Describe your changes

  • [Changed] - Styling allowing for text-overflow in buttons

Before

Screenshot 2024-01-15 at 16 15 19

After

Screenshot 2024-01-15 at 16 15 56

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 44de362

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@justeattakeaway/pie-button Minor
pie-storybook Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ashleynolan
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 15:04 Inactive
@ashleynolan ashleynolan marked this pull request as ready for review January 15, 2024 16:14
@ashleynolan ashleynolan requested review from a team as code owners January 15, 2024 16:14
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 16:20 Inactive
raoufswe
raoufswe previously approved these changes Jan 16, 2024
@ashleynolan ashleynolan marked this pull request as draft January 18, 2024 14:52
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 18, 2024 14:59 Inactive
@ashleynolan ashleynolan dismissed stale reviews from raoufswe and kevinrodrigues via b46c6f7 July 27, 2024 09:34
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 July 27, 2024 09:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 20, 2024 16:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 21, 2024 16:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 22, 2024 11:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 22, 2024 11:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 22, 2024 13:58 Inactive
@ashleynolan ashleynolan marked this pull request as ready for review November 25, 2024 10:21
@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Nov 25, 2024


Fails
🚫 You currently have an unchecked checklist item in your PR description.

Please confirm this check has been carried out – if it's not relevant to your PR, delete this line from the PR checklist.

Generated by 🚫 dangerJS against 44de362

@github-actions github-actions bot temporarily deployed to storybook-testing-pr-1089 November 25, 2024 10:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants