This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Restore window scroll after popup close #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45mg
force-pushed
the
restore-scroll-after-popup-close
branch
from
f610eff to
1105149
Compare
Currently, if displaying the popup would hide point, the window is scrolled to prevent this; but it is not scrolled back when the popup closes. This can be disorienting when the popup is tall, as the scroll changes by a large amount. The solution is to store the scroll position of the selected window before showing the popup, and restore it after closing it.
45mg
force-pushed
the
restore-scroll-after-popup-close
branch
from
1105149 to
40abb43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if displaying the popup would hide point, the window is scrolled to prevent this; but it is not scrolled back when the popup closes. This can be disorienting when the popup is tall, as the scroll changes by a large amount.
The solution is to store the scroll position of the selected window before showing the popup, and restore it after closing it.
#321 added an option to do the same thing, but only for the
side-windowpopup type, and usingset-window-configurationwhich is dangerous as discussed there. This solution should work for any popup function.I didn't remove/deprecate the option introduced in #321, as users may have come to rely on side-effects from
set-window-configuration(but mostly because it would put me over 15 lines 🙂).