Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(redis_interface): make the redis command for using scripts to write into redis Generic #6965

Merged
merged 5 commits into from
Jan 16, 2025
Merged

refactor(redis_interface): make the redis command for using scripts to write into redis Generic #6965

merged 5 commits into from
Jan 16, 2025

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Jan 2, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

make the redis command for using scripts to write into redis Generic, for allowing the flexibility to update the redis

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

wrote a unit test for it

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Aprabhat19 Aprabhat19 self-assigned this Jan 2, 2025
@Aprabhat19 Aprabhat19 requested a review from a team as a code owner January 2, 2025 08:33
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 2, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/redis_interface/src/commands.rs  17% smaller

NishantJoshi00
NishantJoshi00 previously approved these changes Jan 2, 2025
View reviewed changes
@Aprabhat19 Aprabhat19 linked an issue Jan 3, 2025 that may be closed by this pull request
refactor(redis_interface): make the redis command for using scripts to write into redis Generic #6973
Closed
SanchithHegde
SanchithHegde previously approved these changes Jan 4, 2025
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Jan 6, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 3434651 Jan 16, 2025
19 checks passed
@likhinbopanna likhinbopanna deleted the make-redis-command-generic branch January 16, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Aprabhat19 Aprabhat19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(redis_interface): make the redis command for using scripts to write into redis Generic
4 participants
@Aprabhat19 @SanchithHegde @NishantJoshi00 @likhinbopanna