Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update url in setup.py #144

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Update url in setup.py #144

merged 3 commits into from
Aug 25, 2023

Conversation

rcthomas
Copy link
Contributor

The homepage link on the PyPI project page for jupyterlab-hdf points to this fork of the jupyterlab-hdf5 GitHub repo, not the repo in the JupyterLab org. I think maybe this just hasn't been updated? Thanks.

@welcome
Copy link

welcome bot commented Aug 22, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch rcthomas/jupyterlab-hdf5/url-update

Just trying this, it may be this is a discussion
@rcthomas
Copy link
Contributor Author

Originally this PR was just going to fix a package metadata issue. But to make all the checks pass I had to make two additional commits that would be out of place for a PR that's just fixing package metadata. One approach would be to redirect this PR (or consider it) to be a more general "upkeep" PR, but discussion is still needed:

The additional commits upgrade the Node requirement for the build checks, which fail without that change; and requires Notebook <7 so that the test checks pass. I don't know whether jupyterlab-hdf5 works in practice with Notebook v7 or not, but if so the tests need to be rewritten to not depend on notebook.utils which doesn't seem to be provided by Notebook v7. If no one is in a position to revise those tests, and since are no passing tests here for v7, it may make sense to make notebook<7 a requirement until that's addressed.

@loichuder
Copy link
Collaborator

Thanks for fixing the build issues ! I was going to have a look but you beat me to it 🚀

I have no problem merging your PR as it is. It simply moved from URL fixing to more general housekeeping.

In my opinion, notebook<7 is the way to go for now since the tests were written before Notebook 7 was a thing.

@rcthomas
Copy link
Contributor Author

OK. I think these fixes may also address the other 2 outstanding PRs

@loichuder loichuder merged commit 8c86b71 into jupyterlab:master Aug 25, 2023
6 checks passed
@welcome
Copy link

welcome bot commented Aug 25, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants