Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to configure OAuthenticator client_id and client_secret via an existing k8s Secret #3478

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AliaksandrTsimokhau
Copy link

Add a working example of using predefined secret to store ouath client credentials to avoid storing them on github. Example is based on forum discussion https://discourse.jupyter.org/t/jupyterhub-to-github-authentication-using-secrets/19380

AliaksandrTsimokhau and others added 2 commits August 7, 2024 20:03
Add a working example of using predefined secret to store ouath client credentials to avoid storing them on github. Example is based on forum discussion https://discourse.jupyter.org/t/jupyterhub-to-github-authentication-using-secrets/19380
@consideRatio
Copy link
Member

Thank you @AliaksandrTsimokhau!!

I'd like to position this documentation as a way to configure the OAuthenticator based classes client_id and client_secret information from an chart external k8s Secret instead of the chart managed k8s Secret.

I think this documentation belong in this project as its chart specific configuration and not just about the oauthenticator project, but since its not a GoogleOAuthenticator specific documentation I'd like to lift it upwards a bit instead and make it focus just on configuring client_id and client_secret using an existing k8s Secret without in case that is a requirement. I think if we instead of putting it under a Google heading, we can put it as its own heading on the same level as the Google heading. For example above the GitHub Heading here:

image

@consideRatio consideRatio changed the title Update authentication.md docs: how to configure OAuthenticator client_id and client_secret via an existing k8s Secret Sep 18, 2024
@AliaksandrTsimokhau
Copy link
Author

AliaksandrTsimokhau commented Sep 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants