Document how to customize page #1923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
reviewed
Feb 2, 2025
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| BinderHub uses `Jinja <https://jinja.palletsprojects.com/en/stable/>`_ as template engine | ||
| to process the page template `binderhub/templates/page.html <https://github.com/jupyterhub/binderhub/blob/main/binderhub/templates/page.html>`. |
There was a problem hiding this comment.
There's something wrong with the link syntax- it's not linked:
https://binderhub--1923.org.readthedocs.build/en/1923/customizing.html#header-and-footer-customization
There was a problem hiding this comment.
I think it'd be helpful to also highlight the important parts of the template- is <div id="root"></div> the critical bit?
| release: {{ .Release.Name }} | ||
| data: | ||
| {{- (.Files.Glob "files/*").AsConfig | nindent 2 }} | ||
|
|
There was a problem hiding this comment.
Is additional Helm configuration needed to mount the file in the ConfigMap into the BinderHub pod?
|
I will address the comments in a couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1907
We might want to make add a new
traitletsfor users to provide their own Jinja template that will be used inbinderhub/binderhub/main.py
Line 42 in 4f0a91a
binderhub/binderhub/main.py
Lines 41 to 46 in 4f0a91a