-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing grade_cells before autograding #1770
Conversation
Thanks @tuncbkose.
On my side the cell is indeed added, but the status is still need manual grading. I tried deleting an autograded cell. |
On a quick attempt, I couldn't reproduce this. I will investigate, but it would be great if you can let me know what you did step by step. |
On a more involved attempt, still couldn't reproduce this status mismatch. |
My fault, it was actually needed a manual grading. Can you try rebasing on main ? |
958c9ef
to
e4d8b4f
Compare
rebased |
This pr shouldn't change anything for ui tests, so failure is unrelated? |
Thanks @tuncbkose |
@meeseeksdev backport to 0.8.x |
Co-authored-by: tuncbkose <[email protected]>
Add a new flag
OverwriteCells.add_missing_cells
, that, when set toTrue
, compares the submitted notebook to the database before autograding and adds missing grade cells to (approximately) correct locations.Fixes #1682 (with the provided flag).
Notes
released/
directory, but there is no guarantee they are the same. Instructors can overwrite it, in which case the original notebook might not be recoverable. I am not sure if the database is completely safe, but it should be safer.To-dos
If this looks good, I will also