groupshared feedback re-release fix #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is a follow up of #1000, and is live at our site for a while now. It's also nice that it makes feedback releasing an atomic operation, so I think this should be "good to go". Existing tests should cover the actual functionality, and like @franswel said testing the multi-user interaction is probably too hard. |
Gehock
force-pushed
the
multi-instructor-feedback
branch
from
85a92f4
to
406e502
Compare
Gehock
force-pushed
the
multi-instructor-feedback
branch
2 times, most recently
from
0fc9858
to
b995709
Compare
Gehock
force-pushed
the
multi-instructor-feedback
branch
from
b995709
to
f64fa47
Compare
|
Rebased on main. Like Richard mentioned, this has been running in our in our production environment without issues for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groupshared users could not re-release student feedback due to shutil.copy functionality used by release_feedback. Shutil.copy tries to chmod the destination file which does not work in groupshared scenarios where files have different owners but same groups. Therefore groupshared users cannot copy a new generated feedback with the same name over the old one owned by another user. In the fix the file gets copied in a temporary location and is moved over the old file.
Tests were not implemented as I believe it is not possible to test interactions requiring multiple users automatically. To replicate the issue, you need two users with groupshared enabled that release feedback for the same student's assignment.