Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding dependency on ZeroMQ from public headers #33

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Hiding dependency on ZeroMQ from public headers #33

merged 4 commits into from
Feb 9, 2024

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Feb 2, 2024 •
edited
Loading

Towards #32

@anutosh491
Copy link
Collaborator Author

Still need to update some directories like the test directory.

JohanMabille
JohanMabille requested changes Feb 7, 2024
View reviewed changes
include/xeus-zmq/xserver_zmq.hpp Outdated Show resolved Hide resolved
include/xeus-zmq/xserver_zmq.hpp Show resolved Hide resolved
include/xeus-zmq/xserver_zmq.hpp Outdated Show resolved Hide resolved
include/xeus-zmq/xserver_zmq.hpp Outdated Show resolved Hide resolved
@JohanMabille
Copy link
Member

You can also remove the macro XEUS_ZMQ_API from the classes that have been moved to the src folder.

@anutosh491 anutosh491 changed the title [WIP] Hiding dependency on ZeroMQ from public headers Hiding dependency on ZeroMQ from public headers Feb 9, 2024
@JohanMabille JohanMabille merged commit 26bca15 into jupyter-xeus:main Feb 9, 2024
8 checks passed
@anutosh491
Copy link
Collaborator Author

Thanks for the reviews on this !

@anutosh491 anutosh491 deleted the hide_zmq branch February 9, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anutosh491 @JohanMabille