Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unused table cols and added column preprocessor func #2304

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

YellowFoxH4XOR
Copy link
Contributor

Worldometer has removed "UrbanPop" "UrbanPop %" from the table, hence the table was breaking as it does a check if all columns are the same as TABLE_COLS.

Fixes

This PR resolves #2177

What does this PR do?

Fixes the ongoing bug with the Worldometer_World_population_evolution_and_projections.ipynb file

Screenshots

Provide supporting docs, limitations if any, video of the template, or anything that you want to share to support your PR
image

Worldometer has removed "UrbanPop" "UrbanPop %" from the table, hence the table was breaking as it does a check if all columns are the same as TABLE_COLS.
@YellowFoxH4XOR YellowFoxH4XOR self-assigned this Oct 14, 2023
@YellowFoxH4XOR YellowFoxH4XOR added the bug Something isn't working label Oct 14, 2023
@FlorentLvr FlorentLvr requested review from jravenel and srini047 and removed request for jravenel and FlorentLvr October 14, 2023 14:45
Copy link
Member

@srini047 srini047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now.

@srini047 srini047 merged commit d3b7543 into master Oct 16, 2023
5 checks passed
@srini047 srini047 deleted the 2177-bugfix-worldometer branch October 16, 2023 16:16
@github-actions
Copy link

@github-actions
Copy link

Thank you for your contribution @YellowFoxH4XOR, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

YellowFoxH4XOR.png

@FlorentLvr FlorentLvr added the hacktoberfest-accepted Valid PRs for hacktoberfest label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Valid PRs for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worldometer - World population evolution and projections: No table are return
3 participants