Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2255 matplotlib create piechart #2271

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Conversation

MSaiKiran9
Copy link
Contributor

@MSaiKiran9 MSaiKiran9 commented Oct 8, 2023

Fixes

closes : #2255

What does this PR do?

It shows how to use matplotlib piecharts

Screenshots

image

@MSaiKiran9 MSaiKiran9 assigned MSaiKiran9 and unassigned MSaiKiran9 Oct 8, 2023
@FlorentLvr
Copy link
Contributor

@MSaiKiran9, TY for your contribution. Here are my feedbacks:

  • You didn't add your LinkedIn URL in the author cell, could you please add it?
  • I added cell at the end to be able to export the chat and create an asset that could be used outside naas but your code is code created a fig object. Could you please update it following the same example as https://matplotlib.org/stable/plot_types/stats/pie.html#sphx-glr-plot-types-stats-pie-py ? If you have any trouble you can get inspired by the other template like "Matplotlib_Create_Barchart.ipynb"/
    Don't forget to pull before doing new changes.
    Let me know if you have any questions,

@MSaiKiran9
Copy link
Contributor Author

Hi @FlorentLvr can you see if it's okay now ?

@FlorentLvr
Copy link
Contributor

Hi @FlorentLvr can you see if it's okay now ?

@MSaiKiran9, I made a little adjustements but it's good now! For next contribution, please make all variables have a description in the output section and add markdown cell to explain all steps (one was blank in output). TY 🙏

@FlorentLvr FlorentLvr added the hacktoberfest Issues for hacktoberfest label Oct 9, 2023
@FlorentLvr FlorentLvr self-requested a review October 9, 2023 17:31
@FlorentLvr FlorentLvr merged commit 3b5de52 into master Oct 9, 2023
5 checks passed
@FlorentLvr FlorentLvr deleted the 2255-matplotlib-create-piechart branch October 9, 2023 17:31
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/Matplotlib/Matplotlib_Create_Piechart.ipynb

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thank you for your contribution @MSaiKiran9, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

MSaiKiran9.png

@srini047 srini047 added the hacktoberfest-accepted Valid PRs for hacktoberfest label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for hacktoberfest hacktoberfest-accepted Valid PRs for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib - Create Piechart
3 participants