Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 google maps routes api route optimisation #2070

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

tony-georgiev
Copy link
Contributor

No description provided.

@tony-georgiev tony-georgiev added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2023
@tony-georgiev tony-georgiev self-assigned this Jul 31, 2023
@tony-georgiev tony-georgiev linked an issue Jul 31, 2023 that may be closed by this pull request
@tony-georgiev
Copy link
Contributor Author

@FlorentLvr ,
Ready to review.

@gitguardian
Copy link

gitguardian bot commented Aug 7, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
7317223 Generic High Entropy Secret 0748fdc Azure Machine Learning/Azure_Machine_Learning_Univariate_Timeseries_Inference.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@FlorentLvr
Copy link
Contributor

@tony-georgiev! Great work! I made some minor improvments but it is working super well! Let me know if it's good for you and you can merge this PR is so! 👍

@tony-georgiev tony-georgiev merged commit ef4c3dc into master Aug 8, 2023
5 checks passed
@tony-georgiev tony-georgiev deleted the 2020-google-maps-routes-api-route-optimisation branch August 8, 2023 18:57
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Thank you for your contribution @tony-georgiev, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

tony-georgiev.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Maps - Routes API Route optimisation
3 participants