Skip to content

refactor(frontend): rename SignInOpenIdProvider to OpenIdAuthProvider #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 1 commit into from
Feb 19, 2026
Merged

refactor(frontend): rename SignInOpenIdProvider to OpenIdAuthProvider #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/frontend/src/lib/components/auth/sign-in/Authenticate.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
import { getAndClearAuthNavOrigin } from '$lib/services/console/auth/_auth.nav.services';
import { handleRedirectCallback } from '$lib/services/console/auth/auth.openid.services';
import { i18n } from '$lib/stores/app/i18n.store';
import type { SignInOpenIdProvider } from '$lib/types/auth';
import type { OpenIdAuthProvider } from '$lib/types/auth';

interface Props {
provider: SignInOpenIdProvider;
provider: OpenIdAuthProvider;
}

let { provider }: Props = $props();
Expand Down
4 changes: 2 additions & 2 deletions src/frontend/src/lib/components/auth/sign-in/AuthenticateCallback.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
import AlreadySignedIn from '$lib/components/auth/sign-in/AlreadySignedIn.svelte';
import Authenticate from '$lib/components/auth/sign-in/Authenticate.svelte';
import { authSignedIn } from '$lib/derived/auth.derived';
import type { SignInOpenIdProvider } from '$lib/types/auth';
import type { OpenIdAuthProvider } from '$lib/types/auth';

interface Props {
provider: SignInOpenIdProvider;
provider: OpenIdAuthProvider;
}

let { provider }: Props = $props();
Expand Down
6 changes: 3 additions & 3 deletions src/frontend/src/lib/services/console/auth/auth.openid.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import { i18n } from '$lib/stores/app/i18n.store';
import { toasts } from '$lib/stores/app/toasts.store';
import { authStore } from '$lib/stores/auth.store';
import type { SignInOpenIdProvider } from '$lib/types/auth';
import type { OpenIdAuthProvider } from '$lib/types/auth';
import { SignInInitError } from '$lib/types/errors';
import { container } from '$lib/utils/juno.utils';
import { isNullish, nonNullish } from '@dfinity/utils';
Expand Down Expand Up @@ -46,7 +46,7 @@ export const signInWithGitHub = async () => {

interface SignInWithOpenIdParams<T> {
clientId: string | undefined;
provider: SignInOpenIdProvider;
provider: OpenIdAuthProvider;
extraArgs?: T;
}

Expand Down Expand Up @@ -140,7 +140,7 @@ const authenticateWithOpenID = async (params: AuthenticateWithOpenIdRedirectPara
export const handleRedirectCallback = async ({
provider
}: {
provider: SignInOpenIdProvider;
provider: OpenIdAuthProvider;
}): Promise<{
result: 'ok' | 'error';
err?: unknown;
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/lib/types/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ export type SignInWithAuthClient = (params: {
}) => Promise<SignedInIdentity>;
export type SignInWithNewAuthClient = () => Promise<void>;

export type SignInOpenIdProvider = 'google' | 'github';
export type OpenIdAuthProvider = 'google' | 'github';
Loading