-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DisplayNameGenerator
to access runtime enclosing type for @Nested
#4162
base: main
Are you sure you want to change the base?
Conversation
DisplayNameGenerator
to access runtime enclosing type for @Nested
It seems that some existing tests have been affected by the changes in adding |
Which tests fail, and what is the error / stack trace? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old methods of DisplayNameGenerator
(that now throw UnsupportedOperationException
) should neither be called nor implemented anymore.
private static Supplier<String> createDisplayNameSupplierForMethod(Class<?> testClass, Method testMethod, | ||
JupiterConfiguration configuration) { | ||
return createDisplayNameSupplier(testClass, configuration, | ||
generator -> generator.generateDisplayNameForMethod(testClass, testMethod)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method and the one above for nested classes should no longer be used and therefore deleted.
@sbrannen @marcphilipp I'll leave a comment here if I need additional feedback :) |
@neronsoda Any updates? Please let us know if you don't have enough time to finish this and we should take over. |
@marcphilipp |
We'd like to include it in 5.12 which is targeting end of January. So we should try to get this PR merged by mid-January so we'll have enough time to address the issues that depend on it afterwards. |
Okay, I got it. I'm continuing this issue. |
This PR is supposed to resolve the Issue: #4130
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations