Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable julia arg --compiled-modules during testing #91

Merged

Conversation

haberdashPI
Copy link
Contributor

@haberdashPI haberdashPI commented Dec 11, 2023

Let's you specify whether modules should be compiled during tests.

c.f. beacon-biosignals/StableHashTraits.jl#40

@haberdashPI haberdashPI requested a review from a team as a code owner December 11, 2023 15:28
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (303a196) 100.00% compared to head (6514903) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

action.yml Outdated
Comment on lines 36 to 37
description: 'Whether to run tests with `compiled-modules` equal to `yes` or `no`'
default: 'yes'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julia can also take "existing" as an option

Copy link
Contributor Author

@haberdashPI haberdashPI Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly this is not documented in julia --help 🤔 Is that an oversight?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just don't specify the accepted values and point users to the julia docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Okay!

@haberdashPI
Copy link
Contributor Author

Bump! Just checking if there's anything I can to do get this merged.

@IanButterworth IanButterworth enabled auto-merge (squash) January 8, 2024 20:04
@IanButterworth
Copy link
Member

Once this is merged can you give this a try in the wild using the julia-actions/julia-runtest@main tag and check that it works, then I'll make a release

@IanButterworth IanButterworth merged commit 2b24f9b into julia-actions:main Jan 8, 2024
32 checks passed
Copy link
Contributor Author

@haberdashPI haberdashPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged can you give this a try in the wild using the julia-actions/julia-runtest@main tag and check that it works, then I'll make a release

Sounds perfect! I'm going to make a PR to address beacon-biosignals/StableHashTraits.jl#40, and I'll see how it goes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants