-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable julia arg --compiled-modules
during testing
#91
enable julia arg --compiled-modules
during testing
#91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. |
action.yml
Outdated
description: 'Whether to run tests with `compiled-modules` equal to `yes` or `no`' | ||
default: 'yes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Julia can also take "existing" as an option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly this is not documented in julia --help 🤔 Is that an oversight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just don't specify the accepted values and point users to the julia docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense. Okay!
Bump! Just checking if there's anything I can to do get this merged. |
Once this is merged can you give this a try in the wild using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged can you give this a try in the wild using the
julia-actions/julia-runtest@main
tag and check that it works, then I'll make a release
Sounds perfect! I'm going to make a PR to address beacon-biosignals/StableHashTraits.jl#40, and I'll see how it goes there.
Let's you specify whether modules should be compiled during tests.
c.f. beacon-biosignals/StableHashTraits.jl#40