Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a reproducer header #124

Merged
merged 3 commits into from
Oct 18, 2024
Merged

add a reproducer header #124

merged 3 commits into from
Oct 18, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53f7ca9) to head (57de9da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test_harness.jl Outdated Show resolved Hide resolved
@IanButterworth
Copy link
Member Author

CI here doesn't actually seem to run this action in its entirety... that should be fixed.

test_harness.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth force-pushed the ib/test_header branch 2 times, most recently from 96d4d60 to 960deee Compare October 18, 2024 15:31
@IanButterworth IanButterworth marked this pull request as ready for review October 18, 2024 15:38
@IanButterworth IanButterworth requested a review from a team as a code owner October 18, 2024 15:38
@giordano
Copy link
Member

Unfortunately I don't think the git commit is very useful: for workflows triggered by pull requests, that'd be the merge commit, which isn't part of the base repo (for PRs opened from forks), that's only part of the target repo and you need to manually fetch the pr refs. For example you can see that the commit you show in the example above doesn't exist: IanButterworth/SimpleLooper.jl@87649fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants