-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing multiple arguments in test_args #118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! I was just thinking of making a PR like this myself, thanks @m-fila!
I had a couple of small proposals for improvements. Note that I'm just a passer-by, I have no admin rights on the repo.
Co-authored-by: Markus Hauru <[email protected]>
Co-authored-by: Markus Hauru <[email protected]>
290bec0
to
3c62a77
Compare
@IanButterworth is there anything blocking this? I'm pinging you since you merged the original PR adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Sorry for the delay!
Passing multiple
test_args
is a feature inPkg.test
but the action inputtest_args
added in #73 allows only a single argument.Parsing the
test_args
with julia is added to allow passing multiple args intest_args
(as in #73 (comment))Usage example m-fila/Example.jl#1 and CI check https://github.com/m-fila/Example.jl/pull/1/checks#step:6:61
Closes #47