fix: deploy to a closed channel #661
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
reviewed
Jan 31, 2025
| // lead to an inconsistent terraform state. This check is to error out to the user, | ||
| // so they can purposely select the track. | ||
| if deployInfo.Channel != transformedInput.charmChannel { | ||
| return fmt.Errorf("you are trying to publish to a closed channel. Check the channel for the %s", transformedInput.applicationName) |
There was a problem hiding this comment.
in this case the terraform plan is specifying a closed channel, so trying to deploy from a channel, not publish
| // Ensure the new revision or channel is contained | ||
| // in the origin to be saved by juju when AddCharm | ||
| // is called. | ||
| if input.Revision != nil { | ||
| oldOrigin.Revision = input.Revision | ||
| } else if input.Channel != "" { | ||
| if newOrigin.Risk != resolvedOrigin.Risk { | ||
| msg := "you've requested a risk different from the one resolved. Probably the channel was close" |
There was a problem hiding this comment.
i'm not too fond of this message - it needs rewording
There was a problem hiding this comment.
yy, just want to show the approach before polishing the pr.
SimoneDutto
changed the title
hmlanigan
requested changes
Feb 3, 2025
Comment on lines
+416
to
+417
| if deployInfo.Channel != transformedInput.charmChannel { | ||
| return fmt.Errorf("you are trying to publish to a closed channel. Check the channel for the %s", transformedInput.applicationName) |
There was a problem hiding this comment.
You're failing after the application has been deployed, but no local OCI image resources are uploaded? Thus the terraform state will not be saved, but the application exists in juju.
This sounds like a worse state to be in than the one you're trying to solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proposal, if accepted I will change the commit message, add tests and qa steps
Fix #647
To fix the issue we can return an error by checking the planned channel with the one received by the client. In this case if they are trying to publish to a closed channel they get a specific error and users can update their terraform plan to avoid incosistency.