Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 3.5.5 schema and update SCHEMAS.md #1223

Merged

Conversation

james-garner-canonical
Copy link
Contributor

Description

The Juju 3.5.5 schema adds the charm-rev field to ApplicationStatus, but there are no changes to the generated code because this field is present in the 3.6.0 schema that was previously added.

QA Steps

As there are no code changes in this PR, CI outcomes shouldn't be affected

@dimaqq
Copy link
Contributor

dimaqq commented Nov 28, 2024

No code changes, yet the file is different from 3.5.4?
I wonder why, perhaps the specific changes are already covered by 3.6 schema?

@dimaqq
Copy link
Contributor

dimaqq commented Nov 28, 2024

confirming that there are no changes to the generated code.

@james-garner-canonical
Copy link
Contributor Author

No code changes, yet the file is different from 3.5.4?
I wonder why, perhaps the specific changes are already covered by 3.6 schema?

Indeed, the Juju 3.5.5 schema adds the charm-rev field to ApplicationStatus, but there are no changes to the generated code because this field is present in the 3.6.0 schema that was previously added

@james-garner-canonical
Copy link
Contributor Author

/merge

3.5.5 schema adds the charm-rev field to ApplicationStatus, but there
are no changes to the generated code because this field is present in
the 3.6.0 schema that was previously added
@dimaqq
Copy link
Contributor

dimaqq commented Nov 28, 2024

/merge

@jujubot jujubot merged commit be9cdf7 into juju:main Nov 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants