-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #946 from cderici/cleanup-release-process-3.x
#946 #### Description This clears up the release process for the master branch. Apparently I forgot to forward port some of the changes from #921 (that clears it up for the 2.9 branch). A twine check is added for validating the release package *before* trying to upload it. The sphinx sections needed a fix for the rendering of the changelog. Specific rules for sections can be found in here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections #### QA Steps The following command will do the first part of the release process where we generate a package with `setup.py`, and then check that package with `twine check`. ``` $ rm -rf dist && python setup.py sdist && twine check dist/* && rm -rf dist ``` So this command should produce an output that says `PASSED`: ```sh .... .... .... copying juju/client/proxy/factory.py -> juju-3.2.2.0/juju/client/proxy copying juju/client/proxy/proxy.py -> juju-3.2.2.0/juju/client/proxy copying juju/client/proxy/kubernetes/proxy.py -> juju-3.2.2.0/juju/client/proxy/kubernetes Writing juju-3.2.2.0/setup.cfg creating dist Creating tar archive removing 'juju-3.2.2.0' (and everything under it) Checking dist/juju-3.2.2.0.tar.gz: PASSED ```
- Loading branch information
Showing
5 changed files
with
9 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.2.2 | ||
3.2.2.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
readme.read_text(), | ||
changelog.read_text() | ||
) | ||
long_description_content_type = 'text/x-rst' | ||
version = here / 'VERSION' | ||
|
||
setup( | ||
|
@@ -39,6 +40,7 @@ | |
maintainer_email='[email protected]', | ||
description=('Python library for Juju'), | ||
long_description=long_description, | ||
long_description_content_type=long_description_content_type, | ||
url='https://github.com/juju/python-libjuju', | ||
license='Apache 2', | ||
classifiers=[ | ||
|