Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix noble version #51

Merged
merged 3 commits into from
May 15, 2024
Merged

Fix noble version #51

merged 3 commits into from
May 15, 2024

Conversation

jack-w-shaw
Copy link
Member

Fix noble version

noble series was accidentally hardcoded to be ubuntu 24.40

Fix this to be 24.04

wallyworld
wallyworld approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check the windows / mcos test failures

@jack-w-shaw jack-w-shaw merged commit c709cfd into juju:master May 15, 2024
4 checks passed
@jack-w-shaw jack-w-shaw deleted the fix_noble_version branch May 15, 2024 14:26
Aflynn50
Aflynn50 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@Aflynn50 Aflynn50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix, had been meaning to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aflynn50 Aflynn50 Aflynn50 approved these changes

@wallyworld wallyworld wallyworld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-w-shaw @wallyworld @Aflynn50