add schemas for metadata and config #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
cjp256
reviewed
May 28, 2021
There was a problem hiding this comment.
Nicely done! While I'm not knowledgeable enough to review the accuracy of the schema, I like how you organized this.
I only have some nitpicks:
- there are some inconsistencies in the formatting (extra lines in places and not others, field ordering etc.) - perhaps run it through a formatter, or use python's json.dumps(..., sort_keys=True) to quickly do this?
- consider addressing the mixed usage of capitalization, periods, etc. in descriptions to be consistent.
apply @cjp256 suggestions from code review Co-authored-by: Chris Patterson <[email protected]>
johnsca
approved these changes
Jun 10, 2021
|
I'll bring this one up, to see if there are any issues in landing this one. |
|
metadata and config are deprecated, now merged into charmcraft.yaml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #369.
Having json schemas would be very helpful for reducing runtime errors:
charmcraft build