Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingress.yaml service/port, make custom domain more obvious #259

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

matt-perrotti
Copy link
Contributor

Just set this up today so two things would make this easier for others to understand:

  1. Made MY_EXTERNAL_DOMAIN for unique subdomain in YAML files.
  2. Noticed that service for ingress.yaml should be juice-balancer, not just balancer, and needed port 3000, not 8080.

Feel free to reject these edits if they aren't helpful but it took me a bit to figure some of this out so figured this might help others as well.

Just set this up today so two things would make this easier for others to understand:

1. Made MY_EXTERNAL_DOMAIN for unique subdomain in YAML files.
2. Noticed that service for ingress.yaml should be juice-balancer, not just balancer, and needed port 3000, not 8080.
@J12934
Copy link
Member

J12934 commented Nov 15, 2024

Hi @matt-perrotti,
sorry for the confusion. The problems with the port come from the upcoming 8.0.0 release, i changed the naming from juice-balancer to just balancer and the default balancer port to 8080. I already update the docs so that i don't forget about it, but i should have added a disclaimer somewhere to look at the 7.x branch for the time being. will add this to the readme.

The MY_EXTERNAL_DOMAIN we can definitly do, if that would have helped you 👍
Can you change the PR / open a new onew with just that change? Happy to merge that.

Reverted service back.
@matt-perrotti
Copy link
Contributor Author

@J12934 I reverted the ingress.yaml change but left MY_EXTERNAL_DOMAIN in this PR.

@J12934 J12934 merged commit 3b1a1c3 into juice-shop:main Nov 15, 2024
4 checks passed
@J12934 J12934 added the documentation Improvements or additions to documentation label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants