Two steps entry store creation. #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, entry tree was adding the entry directly to the jbk EntryStore.
Now it is a tree steps creation:
- Create a entry tree.
- Flatten the entry tree into a vec
- Add entries from the vec to the jbk::EntryStore.
Notes:
- jbk EntryStore still handle the jbk idx for us, so we still need to use
vow and such.
- The flatten process is not good but:
. We cannot do better for now as we have Arc<Mutex<DirCache>> and it
it prevents us to consume the entry.
. We don't really care as jbk handle idx for us and will reorder the
entries.
. We will fix that really soon.
We don't do concurrent access on the tree, so we can remove the `Arc<Mutex<..>>`.
We now use the same order than jubako : (ParentIdx, Name). Previously we was ensuring that sibling entries was in a contiguous range but nothing more.
This avoid the creation of a HashMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to new jbk api (jubako/jubako#74)
We now have a two steps entry store creation: