Fix failing album cover requests #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jtpox#14 Some conditionals moved to switches to improve clarity.
Target albums instead, and strip out extraneous artists.
- Fixed returning an empty string when the ' (feat.' substring was not found. - Fixed `album` not being stripped, sometimes causing an album/track mismatch. - Narrow search slightly when additional artists are provided by Roon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14 by breaking out album cover fetching from activity updating, only fetching covers during a zone change, and ensuring
PreviousAlbumArt.imageKeyis updated when a request fails.Improves the Discogs API call, by targeting the currently playing album and narrowing via artist+track, rather than targeting the isolated track. This is more consistent at returning the expected cover, avoiding erroneous singles, etc. We also do some basic cleaning of the (woefully inadequate)
three_linedata before sending it to Discogs.