Don't patch the v1beta1 API version with CronJob patch.#2
Open
mplzik wants to merge 1 commit intojsonnet-libs:mainfrom
Open
Don't patch the v1beta1 API version with CronJob patch.#2mplzik wants to merge 1 commit intojsonnet-libs:mainfrom
v1beta1 API version with CronJob patch.#2mplzik wants to merge 1 commit intojsonnet-libs:mainfrom
Conversation
The `v1beta1` API has removed the `v1beta1` `CronJob` and hence, it doesn't make sense to apply the patch here. Since no other objects are being patched in the code, this PR takes the easy route of just removing the `v1beta` patch application. Note that this is mostly a cosmetic change -- using the the `v1beta1` `CronJob` with 1.25+ would fail anyway, but with a slightly confusing error message, e.g.: ``` evaluating jsonnet: RUNTIME ERROR: Attempt to use super when there is no super class. ``` Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v1beta1API has removed thev1beta1CronJoband hence, itdoesn't make sense to apply the patch here. Since no other objects are
being patched in the code, this PR takes the easy route of just removing
the
v1betapatch application.Note that this is mostly a cosmetic change -- using the the
v1beta1CronJobwith 1.25+ would fail anyway, but with a slightly confusingerror message, e.g.:
Signed-off-by: Milan Plzik milan.plzik@grafana.com