Refactor non nullable to required

[niteshsinghal85]

Closes #1856

QUALITY CHECKLIST

• Changes implemented in code
• Complies with our contributing guidelines
• Adapted tests
• Documentation updated

[bkoelman]

Hi @niteshsinghal85, I quickly looked at your PR. You're on the right track, but the changes in the directory JsonApiObjects need to be reverted. And then the changes to PeopleMessageFormatter can be reverted as well. The reason is that nullable and required in OpenAPI have different meanings, so that part can't be easily updated.

[niteshsinghal85]

@bkoelman thanks for the guidance, will take care

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (b907741) to head (785f3b8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1892   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         437      437           
  Lines       14860    14860           
  Branches     2451     2451           
=======================================
  Hits        13708    13708           
  Misses        709      709           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bkoelman]

@niteshsinghal85 I'm sorry to inform you that this PR won't be merged. See #1856 (comment) for the rationale.

[bkoelman]

Apologies for letting you put effort in this. I should have realized this wasn't such a good idea earlier. Just hadn't given it much thought yet.