Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service to allow other plugins to open terminal #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edjubuh
Copy link
Contributor

@edjubuh edjubuh commented Apr 21, 2018

Closing #77 in favor of this.

This PR adds the ability to allow other plugins to consume a terminal-tab service and create Terminals using this plugin.

Some use cases:

@edjubuh
Copy link
Contributor Author

edjubuh commented Apr 21, 2018

From: #77 (comment)

Providing a service is certainly the preferred option here. However, I want to proceed very cautiously due to the obvious security concerns.

This is a terrible excuse, but exposing xterm to other plugins on Atom doesn't feel like much more of an security concern because Atom doesn't treat it as a threat. If a user has been infected with malicious code running inside Atom, there are other facilities to run arbitrary programs/execute arbitrary scripts (BufferedProcess, ChildProcess).

@edjubuh
Copy link
Contributor Author

edjubuh commented Apr 30, 2018

Any update here?

edjubuh added a commit to purduesigbots/atom-bootstrapper that referenced this pull request Aug 28, 2018
- Deprecate usage of build plugin since it's not maintained and won't
  install for users (noseglid/atom-build#569)
- Use terminal-tab-plus over terminal-tab for the service
  (jsmecham/atom-terminal-tab#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant