Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug define elements #67

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions packages/tees-drivers/__test__/src/base/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
const {
Query
} = require('../../../src/base/index');

describe('base/index unit test for getSelector', () => {

let query;
beforeAll(() => {
query = new Query('', { label: 'data-auto-id' });
})

test('The selector is @searchBoxForm @searchBox then return [data-auto-id="searchBoxForm"] [data-auto-id="searchBox"]', () => {
expect(query.getSelector(`@searchBoxForm @searchBox`)).toEqual(`[data-auto-id="searchBoxForm"] [data-auto-id="searchBox"]`);
});

test('The selector is @searchBoxForm input[data-auto-id-test="searchBox"] then return [data-auto-id="searchBoxForm"] input[data-auto-id-test="searchBox"]', () => {
expect(query.getSelector(`@searchBoxForm input[data-auto-id-test="searchBox"]`)).toEqual(`[data-auto-id="searchBoxForm"] input[data-auto-id-test="searchBox"]`);
});

test('If selector is a native css, it will not change"]', () => {
expect(query.getSelector(`[class="searchBoxForm"] input[class="searchBox"]`)).toEqual(`[class="searchBoxForm"] input[class="searchBox"]`);
});

test('The selector is @b_searchboxForm:1 then return [data-auto-id="b_searchboxForm"]:nth-child(1)', () => {
expect(query.getSelector(`@b_searchboxForm:1`)).toEqual(`[data-auto-id="b_searchboxForm"]:nth-child(1)`);
});

test('The selector is @b_searchboxForm:-1 then return [data-auto-id="b_searchboxForm"]:nth-last-child(1)', () => {
expect(query.getSelector(`@b_searchboxForm:-1`)).toEqual(`[data-auto-id="b_searchboxForm"]:nth-last-child(1)`);
});

//TODO: unsupported selector
test('The selector is div@b_searchboxForm then return [div[data-auto-id="b_searchboxForm"]', () => {
expect(query.getSelector(`div@b_searchboxForm`)).not.toEqual(`div[data-auto-id="b_searchboxForm"]`);
});

test('The selector is div@b_searchboxForm then return [div[data-auto-id="b_searchboxForm"]', () => {
expect(query.getSelector(`@b_searchboxForm div@b_searchbox`)).not.toEqual(`[data-auto-id="b_searchboxForm"] div[data-auto-id="b_searchbox"]`);
});

});


describe('base/index unit test for getSelector', () => {
let query;
beforeAll(() => {
query = new Query('', {});
})

test('If selector is a native css, it will not change', () => {
[`[class="searchBox"]`, `[class*="searchBox"] [class="searchBoxForm"]`].forEach((selector) => {
expect(query.getSelector(selector)).toEqual(selector);
})
});

});
23 changes: 9 additions & 14 deletions packages/tees-drivers/src/base/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,15 @@ class Query {

getSelector(selector) {
const labelSign = /^@\s*/;
const isUsingCssSelector = !this._label || labelSign.test(selector);
if (isUsingCssSelector) {
return selector
.replace(labelSign, '')
.split(' ')
.map((_selector) => {
const [labelSelector, index] = _selector.split(':');
const childSelector = index ?
`:nth-${/-/.test(index) ? 'last-' : ''}child(${index.replace('-', '')})` : '';
return `[${this._label}="${labelSelector}"]${childSelector}`;
})
.join(' ');
}
return selector;
return selector.split(' ').map(_selector => {
const [labelSelector, index] = _selector.replace(/^@\s*/, '').split(':');
if (labelSign.test(_selector)) {
return `[${this._label}="${labelSelector}"]${index ?
`:nth-${/-/.test(index) ? 'last-' : ''}child(${index.replace('-', '')})` : ''}`
} else {
return _selector;
}
}).join(' ')
}

async waitFor(param, options, ...args) {
Expand Down