Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipv6 header. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ipv6 header. #6

wants to merge 1 commit into from

Conversation

kevinbird61
Copy link

  • Add the entry for ipv6 in src/arp.c - L199.

jserv
jserv reviewed Aug 15, 2018
View reviewed changes
src/arp.c Outdated
@@ -196,6 +196,11 @@ static int arp_input(const struct ether_hdr *hdr __unused,
LOG(LOG_WARN, "Invalid ARP op: %d", arp.arp_oper);
break;
}
} else if(arp.arp_ptype == ETHER_PROTO_IPV6) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use clang-format -i to indent.

@jserv
Copy link
Owner

jserv commented Aug 15, 2018

Besides IPv6 header, do you have idea for preliminary implementation?

@jserv
Copy link
Owner

jserv commented Aug 15, 2018

Please read How to Write a Git Commit Message carefully.
Do not end the subject line with a period.

@kevinbird61
Copy link
Author

I'm reading the tutorials from level-ip to collate where IPv6 handler can be placed.

@jserv jserv force-pushed the master branch 2 times, most recently from 664f683 to 1a55f19 Compare November 14, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinbird61 @jserv