Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic binary operators #34

Closed
wants to merge 2 commits into from
Closed

add basic binary operators #34

wants to merge 2 commits into from

Conversation

a8m
Copy link
Contributor

@a8m a8m commented Dec 23, 2014

Some of the basic operators, issue #10.
If this PR will approved I'll add the rest too.
Also, it could be great if you expand the README(contributions guidelines, usage, etc..) for this repo and for cfg.js too.

@indutny
Copy link
Member

indutny commented Dec 24, 2014

Very nice! I'm +1 on expanding README.md or adding CONTRIBUTING.md.

While we are here - may I ask you to make commit messages look like: stub: add basic binary opereators and in the commit body Fix #10 ? ;)

@a8m
Copy link
Contributor Author

a8m commented Dec 24, 2014

@indutny cool!
commit message was updated.

@indutny
Copy link
Member

indutny commented Dec 24, 2014

Thank you! :) There are some minor typos, but I'll fix them.

@indutny
Copy link
Member

indutny commented Dec 24, 2014

Landed in 9edf4d4, thank you.

@indutny indutny closed this Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants