splits into two tutorials for setup and fundamentals #661
Conversation
content changes to reflect best practices and use cases
| @@ -4,7 +4,8 @@ | |||
| "contributing", | |||
| { | |||
| "about-jquery": [ | |||
| "how-jquery-works", | |||
| "how-to-setup-jquery", | |||
There was a problem hiding this comment.
We will want to handle a redirect for this I imagine. That should block this being deployed to live. I can handle landing together when this PR is ready.
|
I realize most of this content didn't change, but the big diff made me read most of it over again. I'm not sure if the learn site has the same voice/pronoun rules as API . cc @jquery/content - because of the many types of content learn has, from many others, should we even aim for a prose guide here? |
@gnarf We currently do have 2 prose style guides: We are trying to generalise and merge these on the contribute site: jquery/contribute.jquery.org#75. |
| @@ -0,0 +1,108 @@ | |||
| <script>{ | |||
| "title": "How To Setup jQuery", | |||
| "level": "beginner" | |||
There was a problem hiding this comment.
This are two spaces. Use tabs please :)
|
Thanks for the feedback. I will go through and make all the suggested changes. @gnarf suggested that I reset to make git recognize the file name change (which was lost when I squashed my commits before submitting this PR), and then submit separate pull requests for each tutorial so we can see the diff, which we unfortunately don’t have at the moment. And you don’t want the change to the order.json file, so this PR should probably be closed, and I can submit new ones that have diffs and further edits. |
|
A new PR is fine to me but I don't see much problems with just doing it here as the whole article needs a review anyways. |
content changes to reflect best practices and use cases
fixes #658