Clarifies distinctions between getter and setter methods #656
Conversation
|
LGTM - cc @jquery/content for a second reviewer please |
| $( "h1" ).html( "hello world" ); | ||
| ``` | ||
|
|
||
| ``` | ||
| // The .html() method used as a getter: | ||
| $( "h1" ).html(); | ||
| // The .html() method returns the html from the first h1 element: |
There was a problem hiding this comment.
Perhaps better "the html of the first"?
There was a problem hiding this comment.
Yup, that sounds better.
|
I definitely like the proposed text! |
|
I think it's not actually a "js" exception, but rather a "documentation / content" exception to that rule... We should probably list it on a "Documentation/Content Style Guide" along with the prose rules, etc. Link to and list an exception to the JS Style Guide. |
|
We do have an open contribute.jquery.org PR that adds a prose/documentation style guide, this will be something to include there. I'm petty sure we had this whole discussion earlier, let me search for it tomorrow. |
|
I believe this is where we had this discussion: jquery/contribute.jquery.org#75 (comment) We agreed to use |
|
Thanks for the input. I've updated it to reflect this style. |
|
I'm totally 👍 here - waiting for someone else to confirm before landing. |
|
LGTM 👍 |
| $( "h1" ).html(); | ||
| // > "hello world" | ||
|
|
Fixes gh-655